[Webkit-unassigned] [Bug 15279] Right clicking over text (or multiple spaces) auto selects the word (or multiple spaces) under it

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=15279


aroben at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25104|                            |review+
               Flag|                            |




------- Comment #13 from aroben at apple.com  2008-11-12 15:11 PDT -------
(From update of attachment 25104)
You should set the review flag to "r?" for new patches to indicate that your
patch is ready to review.

> +2008-11-12  aa  <set EMAIL_ADDRESS environment variable>

You should set the EMAIL_ADDRESS environment variable so that prepare-ChangeLog
can fill in your email address correctly. You should also set the
CHANGE_LOG_NAME environment variable to the name you want used in ChangeLogs.

> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * page/EventHandler.cpp:
> +        (WebCore::EventHandler::sendContextMenuEvent):
> +        
> +        Disable word selection on context click for PLATFORM(CHROMIUM).

Normally we reference the Bugzilla bug we're fixing in the ChangeLog. Something
like this:

Chromium fix for Bug 15279: Right clicking over text (or multiple spaces) auto
selects the word (or multiple spaces) under it

<https://bugs.webkit.org/show_bug.cgi?id=15279>

> @@ -1627,8 +1627,9 @@ bool EventHandler::sendContextMenuEvent(
>      IntPoint viewportPos = v->windowToContents(event.pos());
>      MouseEventWithHitTestResults mev = doc->prepareMouseEvent(HitTestRequest(false, true), viewportPos, event);
>  
> -    // Context menu events shouldn't select text in GTK+ applications.
> -#if !PLATFORM(GTK)
> +    // Context menu events shouldn't select text in GTK+ applications or in Chromium.
> +    // TODO: This should probably be configurable by embedders. Consider making it a WebPreferences setting.

We normally use FIXME instead of TODO. If you have filed the bug for
WebPreferences you could reference it here with a URL.

r=me

-Adam


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.