[Webkit-unassigned] [Bug 21427] Implement NSAPI support for WebKit/Mac inside WebCore/plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21427


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25095|review?(hausmann at webkit.org)|review+
               Flag|                            |




------- Comment #14 from hausmann at webkit.org  2008-11-12 06:29 PDT -------
(From update of attachment 25095)
>  public:
>          PlatformPluginWidget platformPluginWidget() const { return m_window; }
> +        void setPlatformPluginWidget(PlatformPluginWidget widget) {
> +                m_window = widget;
> +        }

>From the looks of it other code in WebCore puts simple inline setters in one
line of code.

> +    if (!dispatchNPEvent(record)) {
> +        LOG(Events, "PluginView::setFocus(): Get-focus event not accepted");
> +    }
[...]
> +    if (!m_isStarted) {
> +        // TODO: Draw the "missing plugin" image
> +        return;
> +    }
[...]
> +    if (!dispatchNPEvent(event)) {
> +        LOG(Events, "PluginView::paint(): Paint event not accepted");
> +    }
[...]
> +    if (!dispatchNPEvent(record)) {
> +        LOG(Events, "PluginView::handleKeyboardEvent(): Keyboard event type %d not accepted",
> +                record.what);
> +    } else {
> +        event->setDefaultHandled();
> +    }
[...]
> +    if (!dispatchNPEvent(record)) {
> +        LOG(Events, "PluginView::nullEventTimerFired(): Null event not accepted");
> +    }

All of these one line control clauses should not use braces.

I'm really nitpicking here now :-), so r+ under the condition that you fix them
before landing.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.