[Webkit-unassigned] [Bug 21427] Implement NSAPI support for WebKit/Mac inside WebCore/plugins

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21427


hausmann at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25019|review?                     |review+
               Flag|                            |




------- Comment #10 from hausmann at webkit.org  2008-11-12 02:38 PDT -------
(From update of attachment 25019)
> From 97e0aaaa77ee021c33364169ad55a8c001573073 Mon Sep 17 00:00:00 2001
> From: =?utf-8?q?Tor=20Arne=20Vestb=C3=B8?= <tavestbo at trolltech.com>
> Date: Wed, 17 Sep 2008 16:56:24 +0200
> Subject: [PATCH] =?utf-8?q?2008-11-10=20=20Tor=20Arne=20Vestb=C3=B8=20=20<tavestbo at trolltech.com>?=
> MIME-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: 8bit
> 
>         Reviewed by NOBODY (OOPS!).
> 
>         Implement PluginPackageMac and PluginViewMac, and enable NPAPI support for QtWebKit/Mac

It seems the ChangeLog is missing here.

> --- a/WebCore/plugins/PluginView.cpp
> +++ b/WebCore/plugins/PluginView.cpp
> @@ -138,8 +138,12 @@ void PluginView::frameRectsChanged() const
>  
>  void PluginView::handleEvent(Event* event)
>  {
> -    if (!m_plugin || m_isWindowed)
> +    if (!m_plugin)
>          return;
> +#if !defined(XP_MACOSX)
> +    if (m_isWindowed)
> +        return;
> +#endif

This #ifdef probably deserves a comment.

> @@ -419,6 +423,12 @@ NPError PluginView::setValue(NPPVariable variable, void* value)
>      case NPPVpluginTransparentBool:
>          m_isTransparent = value;
>          return NPERR_NO_ERROR;
> +#if defined(XP_MACOSX)
> +    case NPPVpluginDrawingModel:
> +	return NPERR_NO_ERROR;
> +    case NPPVpluginEventModel:
> +	return NPERR_NO_ERROR;
> +#endif

The indentation is off here.

>          PlatformPluginWidget platformPluginWidget() const { return m_window; }
> +        void setPlatformPluginWidget(PlatformPluginWidget widget) {
> +            if (widget != m_window)
> +                m_window = widget;
> +        }

The assignment is probably faster enough to not require a check for inequality
:)


> +static int modifiersForEvent(UIEventWithKeyState *event)

Misplaced * :)


The rest looks good to me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.