[Webkit-unassigned] [Bug 22189] Track CachedScript decoded data

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22189


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25078|review?                     |review+
               Flag|                            |




------- Comment #2 from mitz at webkit.org  2008-11-11 15:58 PDT -------
(From update of attachment 25078)
> Index: ChangeLog
> ===================================================================
> --- ChangeLog	(revision 38320)
> +++ ChangeLog	(working copy)
> @@ -1,3 +1,19 @@
> +2008-11-11  Sam Weinig  <sam at webkit.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Fix for https://bugs.webkit.org/show_bug.cgi?id=22189
> +        Track CachedScript decoded data
> +
> +        * loader/CachedResource.h:
> +        (WebCore::CachedResource::allClientsRemoved):
> +        (WebCore::CachedResource::destroyDecodedData):
> +        * loader/CachedScript.cpp:
> +        (WebCore::CachedScript::script):
> +        (WebCore::CachedScript::data):
> +        (WebCore::CachedScript::destroyDecodedData):
> +        * loader/CachedScript.h:
> +

You could explain the code changes.

> +    if (m_script.isNull() && m_data) {

You can write this as (!m_script && m_data).

r=me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.