[Webkit-unassigned] [Bug 21261] Add layoutTestController API so that animation layout tests don't have to delay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 11 12:47:30 PST 2008


------- Comment #5 from pol at apple.com  2008-11-11 12:47 PDT -------
(In reply to comment #4)
> The rest of the AnimationController API deals with renderers. I think the
> caller should get the node's renderer and pass that in here.
> Also, I think it should be more obvious that these pause the
> animation/transition, and a comment should indicate that they are used by the
> test harness, and are not intended for general use.
> So I think these should be:
> bool pauseAnimationAt(RenderObject*, const String& animName, double t);
> bool pauseTransitionAt(RenderObject*, int propertyID, double t);

Agreed for renderer, but WebCore is not exposing any API in WebKit to go from
property name to propertyID, so let's keep using the property name.

> What do they do if the animation/transition is in the pause phase? Comments
> should say.

We're deprecating pause anyway, but I added comment at the WebKit header level.

> To be consistent:
> - (BOOL)_pauseAnimation:(NSString*)name onNode:(DOMNode *)node
> atTime:(NSTimeInterval)time;
> - (BOOL)_pauseTransitionOfProperty:(NSString*)cssProperty onNode:(DOMNode
> *)node atTime:(NSTimeInterval)time;


> I think it's worth figuring out how to pass the element directly. We shouldn't
> have to require that elements used
> with this API have an id.

Yes, it'd be "cleaner", but you can't access JS internals from DRT, and already
existing method in DRT that take elements as parameters use their string ids.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list