[Webkit-unassigned] [Bug 22155] New: REGRESSION (r38261): "Created an attachment" links for non-patches link to "Review Patch" page, but should not

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22155

           Summary: REGRESSION (r38261): "Created an attachment" links for
                    non-patches link to "Review Patch" page, but should not
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
               URL: https://bugs.webkit.org/show_bug.cgi?id=3235#c2
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Website
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: darin at apple.com


To reproduce:

1. Go to https://bugs.webkit.org/show_bug.cgi?id=3235#c2

Note that the link in that comment now reads:

> Created an attachment (id=5331)
 --> (https://bugs.webkit.org/attachment.cgi?id=5331&action=view) [review]

The text "[review]" links to the "Review Patch" page for this attachment. But
the attachment is a test case, not a patch, so we should not be linking to
"Review Patch" for it at all. We could probably just omit the "[review]" text
entirely in this case.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.