[Webkit-unassigned] [Bug 20306] [gtk] implements FrameLoaderClient::dispatchDidChangeLocationWithinPage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20306





------- Comment #5 from zecke at selfish.org  2008-11-09 15:26 PDT -------
(From update of attachment 22706)
Let me comment on the style first:


>  void FrameLoaderClient::dispatchDidChangeLocationWithinPage()
>  {
> -    notImplemented();
> +    /* Update the URI
> +     */

// Update the URI

or

/*
 * Update the URI
 */


> +    if (m_frame == webkit_web_view_get_main_frame(webView))
> +        g_signal_emit_by_name(webView, "location-changed-within-page", m_frame);
>  }

early exits (like found in many places):

if (m_frame != webkit_web_get_main_frame(webView))
   return;

g_signal_emit_by_name(webView, "...


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.