[Webkit-unassigned] [Bug 22039] Update LayoutTests/platforms/gtk/Skipped - get the LayoutTests going

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 8 16:31:19 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=22039





------- Comment #12 from zecke at selfish.org  2008-11-08 16:31 PDT -------
(In reply to comment #11)

> Furthermore, a few things I've noticed that would improve results:
>   - deleting a word also deletes the following whitespace

which test do you have in mind? Editing tests or in general? I currently
attempt to understand TextItertator in WebCore/editing.


> Also, new tests should be, as suggested, compared to those of mac port. At the
> moment, I'm diffing a pair of results with a python script which then counts
> changed lines and detects any added or deleted ones. Tested on tests in css1
> directory, 30 tests out of 106 have more or less lines than generated tests
> from mac port. In most cases, this is text continuing in new line.

Yes, and this can have at least two reasons:
  - We don't use the right fonts (e.g. you need the webkit test fonts from the
Nokia/Qt Software site), DRT should add them using fontconfig.. same as the Qt
version of DumpRenderTree

  - We don't set the DPI to 72 for the tests.


> Getting the buildbot to run layout tests on gtk port should also be necessary,
> so we can have a neutral machine running the tests.

Right, I will have to ask Mark to do the change.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list