[Webkit-unassigned] [Bug 21443] Allow HAVE_ACCESSIBILITY to be overridden at build time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21443


ddkilzer at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ddkilzer at webkit.org,
                   |                            |darin at apple.com




------- Comment #6 from ddkilzer at webkit.org  2008-11-08 04:40 PDT -------
(In reply to comment #2)
> (From update of attachment 24155 [edit])
> I don't think this is correct.
> 
> The HAVE_ macros are supposed to represent the presence of a certain underlying
> capability, not whether we want to take advantage of it or not. If we want
> ACCESSIBILITY to be something we can turn on and off, then it probably needs to
> be an ENABLE thing instead.

(In reply to comment #3)
> As Darin says, accessibility should probably have been an ENABLE, not a HAVE.
> Would be nice if the patch could address that.
> 
> Moreover, the #if PLATFORM(MAC) && HAVE(ACCESSIBILITY) change doesn't make much
> sense. If you don't want accessibility in your port, you probably don't want to
> compile the Accessibility* classes in the first place. Can you try wrapping the
> entire classes with HAVE/ENABLE(ACCESSIBILITY) guards instead?

(In reply to comment #5)
> (In reply to comment #2)
> That makes sense, though the purpose is to suppress the underlying capability
> at build time.  I don't object to adding an ENABLE flag as well and requiring
> both to be set, but it seems unnecessarily verbose at first glance (since it
> would just change every occurrence of "HAVE(ACCESSIBILITY)" to
> "HAVE(ACCESSIBILITY) && ENABLE(ACCESSIBILITY)".

See Bug 21802.  I think the underlying assumption is that most (all?) platforms
have some kind of an accessibility layer, so changing HAVE(ACCESSIBILITY) to
ENABLE(ACCESSIBILITY) is the desired fix.

I don't think we want to be sprinkling "#if HAVE(ACCESSIBILITY) &&
ENABLE(ACCESSIBILITY)" everywhere, which seems redundant.  :)


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.