[Webkit-unassigned] [Bug 22122] New: Use a stack-based object to make pushLayoutState() code safer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22122

           Summary: Use a stack-based object to make pushLayoutState() code
                    safer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: simon.fraser at apple.com
                CC: hyatt at apple.com, mitz at webkit.org


6 different renderer classes have code that does:

view()->pushLayoutState(this,...)
...
view()->popLayoutState();

or, in some cases:
if (some condition)
  view()->pushLayoutState(this,...)
else
  view()->disableLayoutState();
...

if (some condition which we hope is the same as before)
  view()->popLayoutState();
else
  view()->enableLayoutState();

There is only one place where we assert that the push/pops matched, and that's
at the outer level.

This is crying out for a stack-based class.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.