[Webkit-unassigned] [Bug 22112] if a <body> has contenteditable=true, it should report a writable AXValue

Thu Nov 6 13:58:34 PST 2008

https://bugs.webkit.org/show_bug.cgi?id=22112

bdakin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24954|review?                     |review+
               Flag|                            |

------- Comment #3 from bdakin at apple.com  2008-11-06 13:58 PDT -------
(From update of attachment 24954)
> Index: WebCore/page/AccessibilityRenderObject.cpp
> ===================================================================
> --- WebCore/page/AccessibilityRenderObject.cpp	(revision 38190)
> +++ WebCore/page/AccessibilityRenderObject.cpp	(working copy)
> @@ -341,6 +341,10 @@ bool AccessibilityRenderObject::isReadOn
>          if (!document)
>              return true;
>          
> +        HTMLElement *body = document->body();
> +        if (body && body->isContentEditable())
> +            return false;
> +        
>          Frame* frame = document->frame();
>          if (!frame)
>              return true;

You should move the star -- should be: HTMLElement* body =…

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(revision 38190)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(working copy)
> @@ -69,8 +69,10 @@ public:
>      JSStringRef attributesOfDocumentLinks();
>      JSStringRef attributesOfChildren();
>      JSStringRef parameterizedAttributeNames();
> -    
> +       

You should fix this whitespace change.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.