[Webkit-unassigned] [Bug 22033] [GTK] CTI/Linux r38064 crashes; JIT requires executable memory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=22033





------- Comment #15 from alp at nuanti.com  2008-11-06 10:31 PDT -------
(From update of attachment 24945)
>Index: JavaScriptCore/ChangeLog
>===================================================================
>--- JavaScriptCore/ChangeLog	(revision 38170)
>+++ JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,23 @@
>+2008-11-06  Alp Toker  <alp at nuanti.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=22033
>+        [GTK] CTI/Linux r38064 crashes; JIT requires executable memory
>+
>+        Mark pages allocated by the FastMalloc mmap code path executable with
>+        PROT_EXEC. This fixes crashes seen on CPUs and kernels that enforce
>+        non-executable memory (like ExecShield on Fedora Linux) when the JIT
>+        is enabled.
>+
>+        This patch does not resolve the issue on debug builds so affected
>+        developers may still need to pass --disable-jit to configure.
>+
>+        * wtf/TCSystemAlloc.cpp:
>+        (TryMmap):
>+        (TryDevMem):
>+        (TCMalloc_SystemRelease):
>+
> 2008-11-06  Kristian Amlie  <kristian.amlie at nokia.com>
> 
>         Reviewed by Simon Hausmann.
>Index: JavaScriptCore/wtf/TCSystemAlloc.cpp
>===================================================================
>--- JavaScriptCore/wtf/TCSystemAlloc.cpp	(revision 38170)
>+++ JavaScriptCore/wtf/TCSystemAlloc.cpp	(working copy)
>@@ -51,6 +51,14 @@
> #include "TCSpinLock.h"
> #include "UnusedParam.h"
> 
>+#if HAVE(MMAP)
>+static const int cProtFlags = PROT_READ | PROT_WRITE
>+#if ENABLE(CTI)

^ Will make this #if ENABLE(CTI) && PLATFORM(GTK) as requested.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.