[Webkit-unassigned] [Bug 21820] Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21820





------- Comment #11 from hbono at chromium.org  2008-11-05 20:54 PDT -------
Thank you for your review and comments.

(In reply to comment #8)
> (From update of attachment 24694 [edit])
> +2008-10-27  Hironori Bono  <hbono at chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: editing/deleting/delete-ligature.html
> +
> +        * editing/Editor.cpp:
> +        (WebCore::Editor::deleteWithDirection):
> +        * editing/EditorCommand.cpp:
> +        (WebCore::CommandEntry::):
> 
> Please describe the reasoning behind your changes here.

Sorry for the lack of descriptions.
I have added them to "WebCore/ChangeLog" and "LayoutTests/ChangeLog".

>              case SelectionController::LEFT:
> -                if (m_frame->document())
> +                if (m_frame->document()) {
> +                    String stringToDelete = plainText(range.get());
> 
> We found recently that deleting a text consumes most of the CPU on the iPhone
> and I'm worried about what performance impact this may have.  Could you
> investigate?

Even though I cannot use iPhones to investigate processing power while deleting
a text, it does not consume so much processing power on Chrome.

> +        <p>This test tests if a ligature "&#x0E27;&#x0E31;" is decomposed
> while deleting it with a back-space key.</p>
>
> Shouldn't you be implementing deleteBackwardByDecomposingPreviousCharacter
> then?

Correctly, this fix changes the behavior of the "DeleteBackward" command to
delete only the last character of a ligature consisting of multiple Unicode
characters. That is, this fix does not decompose many Latin ligatures each of
which consists of one Unicode character, e.g. this fix does not decompose
'à' (U+00E0) to 'a' + '`' but just deletes 'à' itself. Since I'm not
sure this behaviors should be denoted as "decompose", I can move this fix to
"deleteBackwardByDecomposingPreviousCharacter" function if you prefer it.

> Justin


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.