[Webkit-unassigned] [Bug 21820] Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 5 16:38:27 PST 2008


------- Comment #8 from justin.garcia at apple.com  2008-11-05 16:38 PDT -------
(From update of attachment 24694)
+2008-10-27  Hironori Bono  <hbono at chromium.org>
+        Reviewed by NOBODY (OOPS!).
+        Test: editing/deleting/delete-ligature.html
+        * editing/Editor.cpp:
+        (WebCore::Editor::deleteWithDirection):
+        * editing/EditorCommand.cpp:
+        (WebCore::CommandEntry::):

Please describe the reasoning behind your changes here.

             case SelectionController::LEFT:
-                if (m_frame->document())
+                if (m_frame->document()) {
+                    String stringToDelete = plainText(range.get());

We found recently that deleting a text consumes most of the CPU on the iPhone
and I'm worried about what performance impact this may have.  Could you

+        <p>This test tests if a ligature "&#x0E27;&#x0E31;" is decomposed
while deleting it with a back-space key.</p>

Shouldn't you be implementing deleteBackwardByDecomposingPreviousCharacter


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list