[Webkit-unassigned] [Bug 15081] Plug-ins display despite having display: none

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 5 08:11:46 PST 2008


------- Comment #14 from mjs at apple.com  2008-11-05 08:11 PDT -------
(From update of attachment 24909)
Issues with this patch:

1) There shouldn't be a test case in a comment in the code.
2) There *should* be a test case (and expected result) added to LayoutTests.
3) The path contains tabs - it should not. We use all spaces for formatting.
4) I think it would be better style to call
HTMLPluginElement::rendererIsNeeded(style) at the end instead of checking
style->display() directly. If this was done, then the function could be
refactored to do the special case frame check first (if not using fallback or
an image) and then call the base class, which would be more elegant.

However, the change looks substantively correct to me, given mitz's test case.

Please fix at least 1-3, 4 is optional.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list