[Webkit-unassigned] [Bug 21863] Add userData and setUserData methods to History Item
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 4 08:22:27 PST 2008
https://bugs.webkit.org/show_bug.cgi?id=21863
hausmann at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #24858|review? |review+
Flag| |
------- Comment #7 from hausmann at webkit.org 2008-11-04 08:22 PDT -------
(From update of attachment 24858)
> Index: WebCore.pro
> ===================================================================
> --- WebCore.pro (revision 38068)
> +++ WebCore.pro (working copy)
> @@ -1019,6 +1019,7 @@
> bridge/qt/qt_class.cpp \
> bridge/qt/qt_instance.cpp \
> bridge/qt/qt_runtime.cpp \
> + history/qt/HistoryItemQt.cpp \
> page/qt/AccessibilityObjectQt.cpp \
> page/qt/DragControllerQt.cpp \
> page/qt/EventHandlerQt.cpp \
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 38068)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,17 @@
> +2008-11-03 yael <yael.aharon at nokia.com>
> +
> + Reviewed by Brady Eidson.
> +
> + Add methods for getting and setting user data on History Item.
> + This change is limited to QT port only. Tests were added in
> + the patch for https://bugs.webkit.org/show_bug.cgi?id=21864.
> +
> + * WebCore.pro:
> + * history/HistoryItem.h:
> + * history/qt/HistoryItemQt.cpp: Added.
> + (WebCore::HistoryItem::userData):
> + (WebCore::HistoryItem::setUserData):
> +
> 2008-11-02 Xan Lopez <xan at gnome.org>
>
> Reviewed by Holger Freyther.
> Index: history/qt/HistoryItemQt.cpp
> ===================================================================
> --- history/qt/HistoryItemQt.cpp (revision 0)
> +++ history/qt/HistoryItemQt.cpp (revision 0)
> @@ -0,0 +1,35 @@
> +/*
> + Copyright (C) 2008 Nokia
> +
> + This library is free software; you can redistribute it and/or
> + modify it under the terms of the GNU Library General Public
> + License as published by the Free Software Foundation; either
> + version 2 of the License, or (at your option) any later version.
> +
> + This library is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + Library General Public License for more details.
> +
> + You should have received a copy of the GNU Library General Public License
> + along with this library; see the file COPYING.LIB. If not, write to
> + the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + Boston, MA 02110-1301, USA.
> +*/
> +
> +#include "HistoryItem.h"
> +#include <QVariant>
> +
> +namespace WebCore {
> +
> +QVariant HistoryItem::userData()
> +{
> + return m_userData;
> +}
> +
> +void HistoryItem::setUserData(QVariant& userData)
> +{
> + m_userData = userData;
> +}
> +
> +}; // namespace WebCore
> Index: history/HistoryItem.h
> ===================================================================
> --- history/HistoryItem.h (revision 38068)
> +++ history/HistoryItem.h (working copy)
> @@ -41,7 +41,9 @@
> #import <wtf/RetainPtr.h>
> typedef struct objc_object* id;
> #endif
> -
> +#if PLATFORM(QT)
> +#include <QVariant>
> +#endif
> namespace WebCore {
>
> class Document;
> @@ -147,6 +149,10 @@
> id getTransientProperty(const String&) const;
> void setTransientProperty(const String&, id);
> #endif
> +#if PLATFORM(QT)
> + QVariant userData();
> + void setUserData(QVariant& userData);
> +#endif
>
> #ifndef NDEBUG
> int showTree() const;
> @@ -196,6 +202,9 @@
> RetainPtr<id> m_viewState;
> OwnPtr<HashMap<String, RetainPtr<id> > > m_transientProperties;
> #endif
> +#if PLATFORM(QT)
> + QVariant m_userData;
> +#endif
> }; //class HistoryItem
>
> } //namespace WebCore
Looks good. I'm doing some minor cleanups before applying, such as making the
methods inline.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list