[Webkit-unassigned] [Bug 21864] Add userData() and setUserData() methods to QWebHistoryItem.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 3 10:25:38 PST 2008


https://bugs.webkit.org/show_bug.cgi?id=21864





------- Comment #4 from darin at apple.com  2008-11-03 10:25 PDT -------
(In reply to comment #3)
> Sorry for the confusion. I was told that it is easier to review patches if they
> are broken into smaller chunks. If that's not the case, I will not break my
> patches in the future. thanks!

That is indeed true in general. But in this case, the chunks don't have any
good logical separation -- there's just a lower level machinery that's unused
and then adding the API to get at it.

Please don't take this as a general push to make patches larger in the future!
It's good to break things up into the smallest sensible chunks that you can.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list