[Webkit-unassigned] [Bug 19180] speed up SunSpider by optimizing immediate number cases

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=19180





------- Comment #29 from darin at apple.com  2008-05-30 13:34 PDT -------
(In reply to comment #28)
> I'm rather confused about the naming in JSImmediate.h - some "get" functions
> also return a bool to indicate success. That said, this new function just
> implements "ToUInt32" algorithm from ECMA-232 for immediates as far as I can
> tell, and is not really a "get" in the sense that -1 turns into 4294967296. The
> "get" functions that we have do not cast the result like that. I wasn't sure
> what the word "truncated" meant here, but since this function does almost the
> same work as getTruncatedInt32, I kept it.

I can live with this. It's worth redoing the names at some point.

The "truncated" is left over from when immediate numbers could be non-integers.
"Truncated" meant that the function was free to discard the fractional portion
or values that didn't fit in a 32-bit integer.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.