[Webkit-unassigned] [Bug 19180] speed up SunSpider by optimizing immediate number cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 30 07:25:57 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19180


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21430|review?                     |review+
               Flag|                            |




------- Comment #27 from darin at apple.com  2008-05-30 07:25 PDT -------
(From update of attachment 21430)
If you fixed a regression on PowerPC, was there a regression test indicating
it?

+        (KJS::JSImmediate::toTruncatedUInt32): Added. Same as
getTruncatedInt32, but casts the result
+        to unsigned.

I'm concerned about the "to" vs. "get" in the name here. This class seems we
use "get" to mean "convert with no possibility of error" and "to" to mean
"convert with a possible exception or error".

r=me


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list