[Webkit-unassigned] [Bug 19273] BitmapImage.cpp erroneously assumes repetition count is available once size is available

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 28 15:12:45 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19273


zerodpx at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |zerodpx at gmail.com
                   |unassigned at lists.webkit.org |
             Status|NEW                         |ASSIGNED
  Attachment #21404|                            |review?
               Flag|                            |




------- Comment #1 from zerodpx at gmail.com  2008-05-28 15:12 PDT -------
Created an attachment (id=21404)
 --> (http://bugs.webkit.org/attachment.cgi?id=21404&action=view)
patch v1

Here's a patch to fix.  I didn't realize that the GIFImageDecoder deletes
m_reader as soon as the GIF finishes decoding, so I had to add a member to
GIFImageDecoder to hold the repetition count after that point.  (I didn't
bother to plumb a notification from the reader up to the decoder that the count
has changed, since BitmapImage.cpp will only ask for this data either very
early or after the whole image has decoded, so this wouldn't have bought us
anything.)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list