[Webkit-unassigned] [Bug 19043] New window event for wxWebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 28 13:43:09 PDT 2008


kevino at theolliviers.com changed:

           What    |Removed                     |Added
  Attachment #21121|review?(kevino at theolliviers.|review-
               Flag|com)                        |

------- Comment #3 from kevino at theolliviers.com  2008-05-28 13:43 PDT -------
(From update of attachment 21121)
This looks good except for one important detail. When we implement DecidePolicy
events, we need to handle the case in which they are ignored. In this case, if
possible, I think we should restructure the code so that if the
wxWebViewNewWindowEvent is not handled, we will return PolicyIgnore rather than
PolicyUse. We should also offer a "Cancel" event like with BeforeLoad to allow
the app to block certain URLs and let WebCore know that they were blocked. 

Thanks for all your help! :)

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list