[Webkit-unassigned] [Bug 19180] speed up SunSpider by optimizing immediate number cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 28 11:47:50 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19180


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21395|0                           |1
        is obsolete|                            |
  Attachment #21398|                            |review?
               Flag|                            |




------- Comment #22 from ap at webkit.org  2008-05-28 11:47 PDT -------
Created an attachment (id=21398)
 --> (http://bugs.webkit.org/attachment.cgi?id=21398&action=view)
Patch for >>, >>>, ==, ===, !=, !==

Removed the fast path for >>> for now, as it was quite incorrect for negative
numbers, and fixing this results in rather mixed performance changes.

(In reply to comment #21)
> Does this do the correct thing on numbers that have low bits set? 

As far as I can tell, it does.

> What about a 1 shifted right by 1?

That's (7 >> (7 >> 2)) | 3 == (7 >> 1) | 3 == 3, which is correct.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list