[Webkit-unassigned] [Bug 18887] WF2 Support for autofocus controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 27 13:59:12 PDT 2008


adele at apple.com changed:

           What    |Removed                     |Added
  Attachment #21310|review?(adele at apple.com)    |review-
               Flag|                            |

------- Comment #7 from adele at apple.com  2008-05-27 13:59 PDT -------
(From update of attachment 21310)
Great work so far-- you're almost there!  A few comments...

1)The test you added is a good basic test, but it only tests that the attribute
is right.  Not that the focus behavior is right.  It would be nice to add
versions of those Opera tests too for a more thorough test suite.  It would
also be good to have at least one test for "ignoreAutofocus", if that's

2) The ChangeLog should have detailed entries for each change.

3) In HTMLGenericFormElement::attach, you shouldn't need to check for disabled
since that is already checked in focus() by calling supportsFocus() and
isFocusable().  In fact...should isFocusable() include a check for read-only?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list