[Webkit-unassigned] [Bug 18041] DOMNodeRemoved events are sent twice

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 22:47:22 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=18041


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21174|review?                     |review-
               Flag|                            |




------- Comment #4 from darin at apple.com  2008-05-24 22:47 PDT -------
(From update of attachment 21174)
Code change looks perfect. Oops!

The patch needs to include the results of the regression test. That's the
DOMNodeRemovedEvent -expected.txt file.

The regression test should be turned into a text-only test so it doesn't dump
the layout of the elements. That can be done by adding this code:

    if (window.layoutTestController)
        layoutTestController.dumpAsText();

to the test. By doing this, you'll make the test work as-is cross-platform and
also eliminate the need to check in "pixel test results".

Please resubmit the patch with a corrected regression test, and we'll get this
checked in.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list