[Webkit-unassigned] [Bug 17510] Acid3 test 26 takes >33ms

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat May 24 21:49:36 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=17510





------- Comment #28 from darin at apple.com  2008-05-24 21:49 PDT -------
(In reply to comment #26)
> 5) 0.7% in Node::isReadOnlyNode(). This is solely to support entity and entity
> reference nodes in the DOM. But we expand entities so this doesn't normally
> even happen. So it sucks that we have to do this expensive check always at DOM
> mutation time. Unfortunately there are no spare bits in Node. However, Element
> has a 3-bit bitfield, so we could move a flag that only applies to Element
> (such as m_tabIndexSetExplicitly) and then have an m_readOnly flag which is set
> only for EntityReference and Entity nodes (they will never have children so no
> need to do propagation to their descendants). Alternately we could just make
> isReadOnlyNode inline and always returning false.

I'd love to make isReadOnlyNode inline and always return false. But there's a
problem with that. We do support the Document::createEntityReference function.
So while there is a guarantee there are no Entity nodes in the DOM tree, there
is no such guarantee for EntityReference nodes.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list