[Webkit-unassigned] [Bug 12053] SVGPathSeg*(Abs|Rel) classses should be combined to reduce code size
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 20 14:03:17 PDT 2008
http://bugs.webkit.org/show_bug.cgi?id=12053
eric at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #21221|review? |review+
Flag| |
------- Comment #2 from eric at webkit.org 2008-05-20 14:03 PDT -------
(From update of attachment 21221)
+ virtual String toString() const { return pathSegTypeAsLetter() +
String::format(" %.6lg %.6lg", m_x, m_y); }
Might be more efficient if you passed the char as part of the format. Not sure
it matters though.
Generally we encourage each of these to get their own line:
36 : m_x(x), m_y(y), m_r1(r1), m_r2(r2), m_angle(angle),
m_largeArcFlag(largeArcFlag), m_sweepFlag(sweepFlag) {}
In general looks great! I love all the minus lines.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list