[Webkit-unassigned] [Bug 19151] New: prepareForTextInsertion assumes Position is not null (even though it can be)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 20 12:40:08 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19151

           Summary: prepareForTextInsertion assumes Position is not null
                    (even though it can be)
           Product: WebKit
           Version: 525.x (Safari 3.1)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: HTML Editing
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: justin.garcia at apple.com


prepareForTextInsertion assumes Position is not null (even though it can be)

I've seen Safari crash on an internal site a few times.  Seems to be due to a
bad position object:

WebCore::InsertTextCommand::prepareForTextInsertion(WebCore::Position const &)
WebCore::InsertTextCommand::input(WebCore::String const &,bool)
WebCore::CompositeEditCommand::inputText(WebCore::String const &,bool)
WebCore::RemoveFormatCommand::doApply()
WebCore::EditCommand::apply()
WebCore::applyCommand(WTF::PassRefPtr<WebCore::EditCommand>)
WebCore::executeRemoveFormat
WebCore::Editor::Command::execute(WebCore::String const &,WebCore::Event *)

Looking at TOT, looks like Position still could be null.  This is probably
covered by the editing fuzzer, but I'm posting this here anyway just in case
justin has an opinion as to what prepareForTextInsertion should be doing in
this case.

Unfortunately I don't have a reduction (yet).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list