[Webkit-unassigned] [Bug 19091] Update CSS Transforms to latest spec

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 15:29:20 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19091


dino at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21185|                            |review?(hyatt at apple.com)
               Flag|                            |




------- Comment #1 from dino at apple.com  2008-05-15 15:29 PDT -------
Created an attachment (id=21185)
 --> (http://bugs.webkit.org/attachment.cgi?id=21185&action=view)
Updated transforms patch

> In Transform3D.cpp:
> 
> +Transform3D &Transform3D::function() {}
> 
> Move the & to be with the return value, so:
> 
> Transform3D& Transform3D::function() {}

done

> In CodeGeneratorObjC.pm:
> 
> I don't understand this:
> 
> -    return "CSSValue" if $parent eq "SVGColor";
> +    return "CSSValue" if $parent eq "SVGColor" or $parent eq "CSSValueList";

This is needed because the WebKitCSSTransformValue inherits from CSSValueList,
which isn't recognised as a base class, and therefore gets Node as a parent.
Code comes from Weinig.

> In DerivedSources.make:
> 
>   VoidCallback \
> +       WebKitCSSTransformValue \
>    WheelEvent \
> 
> Double-check if tabs are actually used in that file.

Removed, although there are some others in there that are not my fault :)


> I see "KeyframeList" in this patch.  I think that was unintentional.  Can you
> remove it?

Removed


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list