[Webkit-unassigned] [Bug 19028] Implement CSS Animation (with keyframes, events, interfaces, etc)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 15 15:11:58 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19028


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #21179|review?(hyatt at apple.com)    |review-
               Flag|                            |




------- Comment #12 from hyatt at apple.com  2008-05-15 15:11 PDT -------
(From update of attachment 21179)
In Transform3D.cpp:

+Transform3D &Transform3D::function() {}

Move the & to be with the return value, so:

Transform3D& Transform3D::function() {}

In CodeGeneratorObjC.pm:

I don't understand this:

-    return "CSSValue" if $parent eq "SVGColor";
+    return "CSSValue" if $parent eq "SVGColor" or $parent eq "CSSValueList";

In DerivedSources.make:

     VoidCallback \
+       WebKitCSSTransformValue \
     WheelEvent \

Double-check if tabs are actually used in that file.

I see "KeyframeList" in this patch.  I think that was unintentional.  Can you
remove it?

This is very close to being able to land.  I think I'll be able to r+ it with
one more revision.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list