[Webkit-unassigned] [Bug 19044] SquirrelFish: Bogus values enter evaluation when closing over scope with parameter and var with same name

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 11:36:25 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=19044





------- Comment #5 from cwzwarich at uwaterloo.ca  2008-05-14 11:36 PDT -------
(In reply to comment #4)
> > > There are other, more complicated ways to fix this. For example, codegen
> > > changes could ensure exact local register allocation, such that we packed all
> > > duplicates into the same slot. I had a patch to do that a while back.
> > 
> > I think the solution is simpler than this. We just shouldn't make a local
> > variable for an identifier that also appears as a parameter.
> 
> That's the more complicated solution I mentioned above: codegen changes to
> ensure exact register allocation.
> 
> Seems much easier just to change 
> 
> > >     int numRegisters = symbolTable().size();
> 
> to 
> 
> > >     int numRegisters = codeBlock->numLocals.

Except that's wrong, because it still has the wrong behaviour with f.arguments.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list