[Webkit-unassigned] [Bug 18976] REGRESSION (r26474): WebKit fails jQuery test 64 core module: text(String) subtest 1 Check escaped text (createTextNode)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 14 09:52:33 PDT 2008


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #21127|review?                     |review+
               Flag|                            |

------- Comment #10 from darin at apple.com  2008-05-14 09:52 PDT -------
(From update of attachment 21127)
Putting these strings into separate functions might make the code slightly
slower unnecessarily. There's no particular reason these need to be shared
globals, and I had originally used a C-style string because I thought that
would be fast enough; widening the characters from 8-bit to 16-bit should be
fast enough. And using globals at all (not new to this patch) creates
unnecessary threading issues if we ever start tackling them the way we are in

But aside from that entirely-theoretical worry, looks perfect.


Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list