[Webkit-unassigned] [Bug 19028] Implement CSS Animation (with keyframes, events, interfaces, etc)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 13 10:53:01 PDT 2008


------- Comment #5 from hyatt at apple.com  2008-05-13 10:53 PDT -------
(From update of attachment 21107)
This is just comments from a cursory reading, not a real review yet:

I see that the RenderLayer functions are just stubs.  I'd just remove them for
now then.

The class declaration of KeyframeList is indented using very odd style.  Please
pull the inline function definitions back next to the function names (instead
of doing odd spacing to try to line up the braces).

+        // make sure there are no duplicate properties. This is an O(n^2)
+        // but the lists tend to be very short, so it is probably ok

Why are we removing duplicate properties here?  I don't like O(n^2) algorithms
even when the lists are short. :)

+    // tell the animation controller that the style is all setup and it can
start animations

"setup" should be two words.  We usually capitalize the first words of comment
sentences, e.g., "// Tell", not "// tell".

I'm still not convinced keyframes are implemented in a way that really works.

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list