[Webkit-unassigned] [Bug 18887] WF2 Support for autofocus controls

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 9 09:24:50 PDT 2008


adele at apple.com changed:

           What    |Removed                     |Added
  Attachment #20973|review?(adele at apple.com)    |review-
               Flag|                            |

------- Comment #3 from adele at apple.com  2008-05-09 09:24 PDT -------
(From update of attachment 20973)
This is a really good first cut, and I'm glad you posted this patch!

I have  a few things that I'd like you to change.

I think that instead of the code you have in the Document class, you can call
focus() directly from the HTMLGenericFormElement class when you parse the
attribute.  focus() will automatically handle updating the appearance style at
the right time.  You shouldn't need to explicitly call theme()->stateChanged.

If you do all that work in HTMLGenericFormElement, then you shouldn't need the
hasAutofocus method.  You can just do that check when you parse the attr.  And
you can check document->ignoreAutofocus() at that time too.

I think you're on the right track, and I'm looking forward to seeing what you
post next!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list