[Webkit-unassigned] [Bug 18608] [Gtk] WebKitNetworkRequest needs to be finished

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 7 03:56:05 PDT 2008


gns at gnome.org changed:

           What    |Removed                     |Added
  Attachment #20895|review?                     |
               Flag|                            |
  Attachment #20895|0                           |1
        is obsolete|                            |
  Attachment #20999|                            |review?
               Flag|                            |

------- Comment #5 from gns at gnome.org  2008-05-07 03:56 PDT -------
Created an attachment (id=20999)
 --> (http://bugs.webkit.org/attachment.cgi?id=20999&action=view)
Updated implementation, with some more goodies

Messing around with the code answered some of my doubts. By looking at
FrameLoaderClientGtk's needs, and webkitwebframe.cpp I understand that the
original ResourceRequest which I'm mapping needs to be carried with
WebKitNetworkRequest, and updated with the values. Currently I'm carrying a
copy, though, and I update the original where it needs to be updated, such as
in the dispatchWillSendRequest delegate.

Some rough edges still need thought and work; a more memory efficient way of
handling the internal hash table which contains the headers, only creating it
when really needed, for instance.

Also, we still have no implementation for ResourceResponse as
WebKitNetworkResponse, so the new signal I created for webkitwebview,
request-started is missing the redirectResponse argument it should have. I will
write a placeholder to fix this, or perhaps even implemente
WebKitNetworkResponse completely for this patch to land, if you prefer it that

Sounds about right?

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list