[Webkit-unassigned] [Bug 18413] hixie test fails for CSS: sanity tests for relative keyword values of font-size

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 6 20:45:21 PDT 2008


apapirovski at mac.com changed:

           What    |Removed                     |Added
  Attachment #20711|0                           |1
        is obsolete|                            |
  Attachment #20996|                            |review?
               Flag|                            |

------- Comment #5 from apapirovski at mac.com  2008-05-06 20:45 PDT -------
Created an attachment (id=20996)
 --> (http://bugs.webkit.org/attachment.cgi?id=20996&action=view)
patch 2

Ok, this took a while, but I pretty much completely changed what it does... now
the behavior matches Firefox. If the original value is within the table or
within 0.5 of the table, then just find the next/previous value from the table,
otherwise extrapolate a value based on the position between the two closest
values. Also, now it doesn't just use ratios if medium size is outside the
range, it creates its own table and then uses that to do everything else.

I'm not a fan of how the code looks now, but I'm having hard time coming up
with anything better, so any ideas are welcome... or if it's fine the way it
is, that's fine by me.

A ton of test results need to be regenerated btw, because they use larger or
smaller keywords or use big/small html tags, but I didn't put those in the

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list