[Webkit-unassigned] [Bug 18725] Make postMessage asynchronous
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 6 09:20:52 PDT 2008
http://bugs.webkit.org/show_bug.cgi?id=18725
sam at webkit.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20978|review? |review+
Flag| |
------- Comment #9 from sam at webkit.org 2008-05-06 09:20 PDT -------
(From update of attachment 20978)
I assume this is due to a change in the spec. Could you note this in the
changelog.
- : Event(messageEvent, true, true)
+ : Event(messageEvent, false, true)
I don't think these need to take PassRefPtrs. You are not transferring
ownership, you just want the timer to ref the objects.
+ PostMessageTimer(PassRefPtr<DOMWindow> window, PassRefPtr<MessageEvent>
event, PassRefPtr<SecurityOrigin> targetOrigin)
The leading { should be on its own line. I am not sure about the 'delete
this'. In the DOMWindowTimer case, we have the the postMessageTimerFired
equivalent in JSDOMWindowBase delete the timer. I think either is fine though.
+ virtual void fired() {
+ m_window->postMessageTimerFired(this);
+ delete this;
+ }
I think this would look better on one line.
+ PostMessageTimer* timer = new PostMessageTimer(
+ this, new MessageEvent(message, sourceOrigin, source), target);
Is the actual security check done in the postMessageTimerFired because of a
possibility that the document has changed since the timer was fired?
This looks great.
r=me
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list