[Webkit-unassigned] [Bug 18859] SVGRootInlineBox::buildTextChunks can do an invalid downcast
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat May 3 13:39:01 PDT 2008
http://bugs.webkit.org/show_bug.cgi?id=18859
rwlbuis at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #20937|review? |review-
Flag| |
------- Comment #2 from rwlbuis at gmail.com 2008-05-03 13:39 PDT -------
(From update of attachment 20937)
The general idea seems good to me. The braces in the if/else are not needed
since the blocks
are both single line.
Please include a testcase in the patch that would crash in the old situation
and work
fine with the patch.
r- because of the missing testcase.
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list