[Webkit-unassigned] [Bug 18855] New: Mechanism for storing line numbers and source URLs in JavaScript exceptions needs improvement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri May 2 14:42:28 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=18855

           Summary: Mechanism for storing line numbers and source URLs in
                    JavaScript exceptions needs improvement
           Product: WebKit
           Version: 523.x (Safari 3)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Keywords: HasReduction, NeedsRadar, ReviewedForRadar
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org


* SUMMARY
The mechanism for storing line numbers and source URLs for JavaScript
exceptions fails to work in the following cases:

- Throwing any non-object (like a string or a number)
- Throwing any object with a property named "line" or a property named
"sourceURL"

What JavaScriptCore does now (in KJS::Node::handleException()) is to *modify*
the exception object to add the "line" and "sourceURL" properties (but only if
neither currently exist).  It seems wrong to modify a JavaScript object simply
to store metadata and obviously doesn't work if the exception is not an object.

* STEPS TO REPRODUCE
1. Launch Safari/WebKit.
2. Open the Web Inspector.
3. Open one of the attached test cases.

* RESULTS
No line number or source URL is provided for the exceptions thrown in the test
cases.

* REGRESSION
I don't think this is a regression.  The code to set the "line" and "sourceURL"
properties on the exception object existed as far back as r9352 in nodes.cpp.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list