[Webkit-unassigned] [Bug 16923] Attr nodes with a value of "" should not have any childNodes
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 2 14:35:33 PDT 2008
http://bugs.webkit.org/show_bug.cgi?id=16923
------- Comment #10 from shadow2531 at gmail.com 2008-05-02 14:35 PDT -------
(In reply to comment #5)
> Yes, this looks quite reasonable.
>
> I'd try to use Attr::createTextChild() here. Also, the test case needs to
> verify what happens to attributes created by the parser - since we only create
> Attr nodes on demand, the relationship between Attr and Attribute is tricky.
Well, I tried:
if (!v.isEmpty())
appendChild(document()->createTextNode(v), e);
and that seems to do the trick.
Now, if I use createTextChild instead like you suggest, does that mean I have
to put:
if (!v.isEmpty())
createTextChild()
*after*, the m_attribute->setValue(v.impl()); line?
--
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
More information about the webkit-unassigned
mailing list