[Webkit-unassigned] [Bug 18662] Extend keyboard navigation

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18662


marco.barisione at collabora.co.uk changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20923|                            |review?
               Flag|                            |




------- Comment #2 from marco.barisione at collabora.co.uk  2008-05-02 07:33 PDT -------
Created an attachment (id=20923)
 --> (http://bugs.webkit.org/attachment.cgi?id=20923&action=view)
Add directional navigation to WebCore

I set the review ? flag because I need a review and some help but the patch is
not ready to be committed as is.

Some comments:
1) realLocation() is just an hack, I didn't find a better way to do it and atm
it doesn't work with iframes. I tried with RenderObject::absolutePosition() but
it returns the position of the block containing an <a>, not of the link itself.
2) I added new values to FocusDirection and then we have only one public method
to move focus, but it just calls two different private methods based on the
direction. Is it better to have 2 different public methods?


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.