[Webkit-unassigned] [Bug 16947] [GTK] Missing HTTP Auth challenge

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=16947


elle.uca at libero.it changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |elle.uca at libero.it




------- Comment #16 from elle.uca at libero.it  2008-05-02 06:40 PDT -------
There are other GNOME/GTK+ HIG "violations"

>+    gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_REJECT);

Some missing calls:
  gtk_dialog_set_has_separator(GTK_DIALOG(dialog), FALSE);
  gtk_container_set_border_width (GTK_CONTAINER (dialog), 5);
  gtk_box_set_spacing (GTK_BOX (GTK_DIALOG (dialog)->vbox), 2);

those (plus the other _set_border_width below) are needed to ensure 12 pixels
spacing between inner widgets and dialog border and between the button area

>+    table = gtk_table_new(2, 2, FALSE);
>+    gtk_table_set_col_spacings(GTK_TABLE(table), 3);
>+    gtk_table_set_row_spacings(GTK_TABLE(table), 3);

col_spacings should be 12 pixels, row_spacings should be 6 pixels.

Plus add
  gtk_container_set_border_width (GTK_CONTAINER(table), 5);

>+    label = gtk_label_new("Username:");
<snip>
>+    label = gtk_label_new("Password:");

missing accelerators ("_Username:" and "_Password:") and missing l10n/i18n


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.