[Webkit-unassigned] [Bug 18044] Timer Bug

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=18044


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #20114|review?                     |review-
               Flag|                            |




------- Comment #9 from darin at apple.com  2008-03-27 11:34 PDT -------
(From update of attachment 20114)
Could you fix the formatting of this patch? The comments are not matching the
style of the surrounding comments (all lowercase, no space after the //,
multiple spaces in one place, no capital letters on the sentences).

Could you reword the comments to be clearer and use more straightforward
technology? What's a "bool guard"?

This sequence seems obviously wrong:

+        if (timersReadyToFire)
+            timersReadyToFire->remove(timer);
+        if(!timersReadyToFire->size())
+            timersReadyToFire = 0;

If timersReadyToFire is 0, then we're going to crash dereferencing the pointer.

I don't understand the change log comment at all. In what sense does this
change make anything "generic"?

I think this change to the Timer class may be an incorrect workaround for a bug
elsewhere.

The logic here seems really muddled. The old change gave a special meaning to a
timersReadyToFire value of 0. Just setting it to zero because you fired the
last timer is not at all consistent with that design.

I believe the correct fix is to add a call to fireTimersInNestedEventLoop
somewhere.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.