[Webkit-unassigned] [Bug 17051] safari should treat "url()" as a valid CSS value

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17051


julien.chaffraix at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julien.chaffraix at gmail.com




------- Comment #17 from julien.chaffraix at gmail.com  2008-03-23 11:47 PDT -------
>$ svn-create-patch
>?      WebKitLibraries/win/include/TargetConditionals.h
>?      WebKitLibraries/win/include/stdint.h
>?      WebKitLibraries/win/include/AssertMacros.h
>?      WebKitLibraries/win/include/stdbool.h
>?      WebKitLibraries/win/include/unistd.h
>?      WebKitLibraries/win/include/ConditionalMacros.h
>?      WebKitLibraries/win/include/AvailabilityMacros.h
>?      WebKitLibraries/win/include/xlocale.h
>?      WebKitLibraries/win/include/SafariTheme/SafariTheme.h
>?      WebKitLibraries/win/lib/CoreFoundation.lib
>?      WebKitLibraries/win/lib/CFNetwork.lib
>?      WebKitLibraries/win/lib/CoreGraphics.lib
>?      WebKit/win/WebKit.vcproj/tmp.obj
>?      WebKit/win/WebKit.vcproj/Thumbs.db
>?      BugsSite/Thumbs.db
>?      WebCore/Resources/Thumbs.db
>?      WebCore/css/CSSPropertyNames.cpp
>?      WebCore/css/CSSValueKeywords.gperf
>?      WebCore/css/CSSPropertyNames.gperf
>?      WebCore/css/CSSValueKeywords.c
>?      WebCore/WebCore.vcproj/tmp.obj
>?      LayoutTests/platform/win/css2.1/t17051-url-empty-expected.txt
>?      WebKitTools/WinLauncher/Thumbs.db
>?      WebKitTools/WinLauncher/WinLauncher.vcproj.MARKTHREEDESK.Bradley.user
>?      WebKitTools/CodeCoverage/Thumbs.db

We do not include the command line and the files not tracked by svn (it is only
a reminder in case you have forgotten a file).

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog   (revision 31235)
>+++ WebCore/ChangeLog   (working copy)
>@@ -1,3 +1,17 @@
>+2008-03-22  Bradley  <set EMAIL_ADDRESS environment variable>
>+

You should set the EMAIL_ADDRESS variable (maybe CHANGE_LOG_NAME too).

>+        Reviewed by NOBODY (OOPS!).
>+
>+        Test: css2.1/t17051-url-empty.html
>+
>+        * css/CSSHelper.cpp:
>+        (WebCore::parseURL):
>+        * css/CSSParser.cpp:
>+        (WebCore::CSSParser::parseValue):
>+        (WebCore::CSSParser::parseBackgroundImage):
>+        (WebCore::CSSParser::parseBorderImage):
>+        * css/makevalues.pl:
>+

See the other entries in the ChangeLog : it usually starts with the bug number
and the bug summary (or at least the link to the bug).
Some explanations of the changes could also be helpful.

> 2008-03-22  Marco Barisione  <marco.barisione at collabora.co.uk>
>
>         Reviewed by Darin Adler.
>Index: WebCore/css/CSSHelper.cpp
>===================================================================
>--- WebCore/css/CSSHelper.cpp   (revision 31183)
>+++ WebCore/css/CSSHelper.cpp   (working copy)
>@@ -43,6 +43,7 @@ String parseURL(const String& url)
>     while (l > 0 && (*i)[o + l - 1] <= ' ')
>         --l;
>
>+       //Check for "url(" at beginning and ")" at the end of url
>     if (l >= 5
>             && ((*i)[o] == 'u' || (*i)[o] == 'U')
>             && ((*i)[o + 1] == 'r' || (*i)[o + 1] == 'R')

The comment should have the same indentation as the following 'if'. We put a
space between the "//" and the start of the comment too.

>Index: WebCore/css/CSSParser.cpp
>===================================================================
>--- WebCore/css/CSSParser.cpp   (revision 31183)
>+++ WebCore/css/CSSParser.cpp   (working copy)
>@@ -853,10 +853,10 @@ bool CSSParser::parseValue(int propId, b
>             } else if(strict && nrcoords == 2)
>                 hotspot = IntPoint(coords[0], coords[1]);
>             if (strict || coords.size() == 0) {
>-                if (!uri.isEmpty()) {
>+                if (!uri.isNull()) {
>                     list->append(new CSSCursorImageValue(KURL(styleElement->baseURL(), uri).string(),
>                         hotspot, styleElement));
>-                }
>+                               }

Indentation issue here too.

>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog       (revision 31235)
>+++ LayoutTests/ChangeLog       (working copy)
>@@ -1,3 +1,9 @@
>+2008-03-22  Bradley  <set EMAIL_ADDRESS environment variable>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * css2.1/t17051-url-empty.html: Added.
>+

Same issues as the other ChangeLog.

> 2008-03-22  Eric Seidel  <eric at webkit.org>
>
>         Update a (passing) result I missed in my last checkin.  No review.
>Index: LayoutTests/css2.1/t17051-url-empty.html
>===================================================================
>--- LayoutTests/css2.1/t17051-url-empty.html    (revision 0)
>+++ LayoutTests/css2.1/t17051-url-empty.html    (revision 0)
>@@ -0,0 +1,13 @@
>+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
>+<html xmlns="http://www.w3.org/1999/xhtml" lang="utf-8"><head>
>+<style type="text/css">
>+body {
>+    background: red url('support/cat.png');
>+    background: green url();
>+}
>+</style>
>+</head>
>+<body>
>+There should be no cats in the background.
>+</body>
>+</html>
>
>Property changes on: LayoutTests/css2.1/t17051-url-empty.html
>___________________________________________________________________
>Name: svn:executable
>   + *

You are missing the results for the test case (see
http://webkit.org/coding/contributing.html for how to generate them).


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.