[Webkit-unassigned] [Bug 17679] Shared PluginView implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 17 23:44:07 PDT 2008


jhoneycutt at apple.com changed:

           What    |Removed                     |Added
  Attachment #19856|review?                     |review+
               Flag|                            |

------- Comment #5 from jhoneycutt at apple.com  2008-03-17 23:44 PDT -------
(From update of attachment 19856)
This looks good to me, a couple of minor things:

16         * WebCoreSOurces.bkl:

Capital 'O'

69 void PluginView::invalidateRegion(NPRegion) {notImplemented(); }

Missing a space.

Should combine the private members in PluginView.h that are wrapped in #if

Looks like you're missing PluginMessageThrottlerWin.{h,cpp}.

r=me if you add the missing files, and thanks!

Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list