[Webkit-unassigned] [Bug 17873] Encoding override should not be persistent

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17873


johnnyding.webkit at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org,
                   |                            |darin at apple.com




------- Comment #1 from johnnyding.webkit at gmail.com  2008-03-15 23:59 PDT -------
The encoding override functionality (in WebView::setCustomTextEncoding) calls
FrameLoader::reloadAllowingStaleData to override encoding.  Since the
FrameLoadType:FrameLoadTypeReloadAllowingStaleData is only used to reload
current page by using user-selected encoding. So I think the easy way to fix
his problem is

In DocumentLoader::overrideEncoding()
Check wthether current page's load type is reloadAllowingStaleData, If yes,
then return right override encoding info, othervise return empty encoding.
In FrameLoader::void FrameLoader::load(const KURL& newURL, const String&
referrer, FrameLoadType newLoadType,const String& frameName, Event* event,
PassRefPtr<FormState> formState)
Do not change the load type to FrameLoadTypeSame when load URL is same URL, but
load type is reloadAllowingStaleData, then the child frame can get correct load
type.

If WebKit want to follow FireFox way, do not reset the encoding override when
new page is opened in child-frame. just need to check whether the load type of
ancestor of the child-frame is FrameLoadTypeReloadAllowingStaleData or not.

A patch is coming soon


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.