[Webkit-unassigned] [Bug 17852] New: _NPN_IntFromIdentifier is wrong

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17852

           Summary: _NPN_IntFromIdentifier is wrong
           Product: WebKit
           Version: 525+ (Nightly build)
          Platform: Macintosh
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Plug-ins
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org


_NPN_IntFromIdentifier is wrong

int32_t _NPN_IntFromIdentifier(NPIdentifier identifier)
{
    PrivateIdentifier* i = (PrivateIdentifier*)identifier;
    if (!i->isString)
        return 0;
    return i->value.number;
}


The check should be if (i->isString) instead of !i->isString

This is a one line fix.  The test case is the PITA.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.