[Webkit-unassigned] [Bug 17133] Should support pausing JavaScript execution without hanging the process

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17133


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19744|review?                     |review+
               Flag|                            |




------- Comment #30 from ap at webkit.org  2008-03-14 09:37 PDT -------
(From update of attachment 19744)
r=me

+                               RelativePath="..\platform\MainThreadInternal.h"

I'm not sure if I love the file name "MainThreadInternal" - Internal has all
sorts of connotations, which do not apply here :)

I think I'd just keep these functions in the same file, although either way is
OK with me.

-    if (processingCustomThreadingMessage)
-        LOG(Threading, "callOnMainThread() called recursively.  Beware of
nested PostMessage()s");
+    if (dispatchingCallbacks)
+        LOG(Threading, "callOnMainThread() called recursively.");

I do not understand this check. What's the problem with a thread making a
callback when the main thread is working through previous ones (possibly from
other threads)? I suggest removing it, if a reason doesn't come up.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.