[Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17730


zucker at wake3.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #19625|0                           |1
        is obsolete|                            |




------- Comment #7 from zucker at wake3.com  2008-03-10 12:29 PDT -------
Created an attachment (id=19640)
 --> (http://bugs.webkit.org/attachment.cgi?id=19640&action=view)
updated Curl patch

Fixes Problems identified by Aroben:
(does not yet include response to bfulgham's comments)

You should set the CHANGE_LOG_NAME and CHANGE_LOG_EMAIL_ADDRESS environment
variables so that this first line will be generated correctly.

>>done

This change will break the CG-based builds. We need some way of having both
configurations co-existing. We also don't land commented-out code.

>>done.  config.h is reverted.

Every file in this new filter needs to be excluded from the three CG-based
configurations: Debug, Release, and Debug_Internal.

>>done

Please put the justification for this change in your ChangeLog.

>>done

Please put the justification for the ForEachCoClass.h changes in you ChangeLog.

>>done

This new #include is misplaced. It should be placed in ASCII order with the
second paragraph of #includes. Ditto for WebError.cpp,
WebMutableURLRequest.cpp, WebURLAuthenticationChallenge.cpp.

>>done


It looks like the indentation of the if line is wrong. We use 4-space indents,
no tabs. This occurs elsewhere throughout your patch.

>>done.  I fixed all the problem areas I could find.  Please let me know if I missed any.

The case of the filename is "NotImplemented.h". Please change your #includes to
match.

>>done

It looks like this patch adds WinLauncher.vcproj to WebKit.sln. I believe we
already have another bug for doing that, so I'd rather it not be included in
this patch.

>>done (removed WinLauncher.vcproj)


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.