[Webkit-unassigned] [Bug 17730] Allows Windows version to use Curl

[bugzilla-daemon at webkit.org]

http://bugs.webkit.org/show_bug.cgi?id=17730





------- Comment #5 from bfulgham at gmail.com  2008-03-10 09:43 PDT -------
Dan -- welcome to the world of peer-reviewed source patches!  Don't lose hope
-- the result will be better than you expect, and well worth the revisions.

WebKit/win/WebError.cpp (WebError::sslPeerCertificate):
In addition to the region you alread excluded, I notice that a few lines
further down we have a call to 'wkGetSSLPeerCertificateData'.  This is an
internal platform API which we should also excluded.

I have discovered the same problem with some of my CoreGraphics changes, as
there are a few font-handling routines in the 'wk' namespace I must get rid of.

We might want to break this into three files:  WebError (common stuff),
WebErrorCF (CFNetwork stuff) and WebErrorCurl.

WebKit/win/WebFrame.cpp:
Again, we have a fairly small chunk of this file that is CFNetwork-specific. 
Maybe we should move the download chunk into its own file (WebDownloadCF.cpp
and WebDownloadCurl.cpp)?

It also looks like some of my temporary CoreGraphics diff is in this file, as
the "spoolPages" has a #if(CG) around it when you use my manual patch; it looks
like the tail end of that is in this revision.

WebKit/win/WebMutableURLRequest.cpp:
This whole patch might go away if we just stub out something in the Curl-based
ResourceHandle to issue a "NotImplemented" when calling
ResourceHandle::setHostAllowsAnyHTTPSCertificate.

Similarly, maybe we should move the certificate stuff into its own file so that
we can just stub out the Curl things until we have valid implementations.

WebKit/win/WebURLAuthenticationChallenge.cpp:
WebKit/win/WebURLAuthenticationChallengeSender.cpp:
It seems like both of these changes could go away if we provided stub
implementations in the WebURLAuthenticationChallenge stuff.

WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:
ditto above


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.