[Webkit-unassigned] [Bug 17732] An external JavaScript, after changing its src attribute, which has not charset declaration in its script tag and encoding info in corresponding http response, can not be correctly decoded.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 10 00:01:01 PDT 2008


http://bugs.webkit.org/show_bug.cgi?id=17732


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




------- Comment #6 from ap at webkit.org  2008-03-10 00:01 PDT -------
Looking great!

The code in parseMappedAttribute() still doesn't quite match what we have in
insertedIntoDocument(). The latter also calls stripWhiteSpace(). I suggest
creating a helper function that would be called from both places, rather than
duplicating the logic.

+         script_obj.src =
"./resources/script-decoding-error-after-setting-src.js";

I'm surprised that this works without
layoutTestController.waitUntilDone()/notifyDone().

+    This case is for testing script decoding error after setting its src
attribute.<br>

A link to this bug would be helpful. Also, I would omit the word "error" here.

In the future, please set review flag on patches - this ensures that they get
into review queue and don't get lost.


-- 
Configure bugmail: http://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list